Week_7: Alexander Gabor // incomplete // code only no CSS (yet)#447
Open
Alexander-Gabor wants to merge 4 commits intoTechnigo:masterfrom
Open
Week_7: Alexander Gabor // incomplete // code only no CSS (yet)#447Alexander-Gabor wants to merge 4 commits intoTechnigo:masterfrom
Alexander-Gabor wants to merge 4 commits intoTechnigo:masterfrom
Conversation
theresBL
reviewed
Mar 29, 2023
theresBL
left a comment
theresBL
left a comment
There was a problem hiding this comment.
Great job Alexander. Overall not that much to say, your app is working fine!
I know that you struggled this week and 'm super impressed that you've come this far. It's just the css left...
I love the clean App and maybe the Feed-component can be cleaned up a bit as well. Maybe with a Card-component?
As I said at the start. There is not much to say, you did an awesome job. As always!
Comment on lines
5
to
11
| export const App = () => { | ||
| return ( | ||
| <div> | ||
| Find me in src/app.js! | ||
| <div className="feed-wrapper"> | ||
| <Feed /> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
So nice looking whit a clean app-file. Good job!
| // Fetching | ||
|
|
||
| const fetchHappy = () => { | ||
| fetch(APIEndpoint) |
| .catch((error) => console.log(error)) | ||
| .finally(() => { console.log('fetch was successful') }); | ||
| } | ||
| // Sending |
added 3 commits
April 2, 2023 20:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://happythoughtshappy.netlify.app/