Open
Conversation
…ed database logic.
… This endpoint returns the complete list of elves from the elves database
… on title, find unique id, and testing the server. Mongoose has not been implemented on those endpoints yet.
… for this project. Change package.json to copy all files from folder Data to dist
…n the elves.json file
…_code or languages. Update the Mongoode model.
… from Name to name.
…int using query params. Limit to get the top twelve, and filter to find the title.
…gic. REmove the old dist folder and create a new one.
…rser, since Render says it is not needed.
…to ensure MongoDB is connected before handling requests.
…snippet for seeding to importing the seedDatabase component, still outcommented since it is not in use
…bject, just like the other statuses in the code.
HIPPIEKICK
approved these changes
Dec 18, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Solid work, Johanna, keep it up 👍
Comment on lines
+87
to
+109
| app.get("/elves", async (request, response) => { | ||
| try { | ||
| const { title, top_twelves } = request.query; | ||
| const query = {}; | ||
|
|
||
| // Filter based on query params | ||
| if (title) { | ||
| // Case insensitive by using Regular Expression | ||
| query.title = new RegExp(title, "i"); | ||
| } | ||
|
|
||
| // Limit to get the top 12 elves, the "TwElves", if "top_twelves=true" | ||
| const limit = top_twelves === "true" ? 12 : 0; | ||
| const elves = await Elf.find(query) | ||
| .sort({ elfID: 1 }) // Sort elfID in ascending order (1 for ascending, -1 for descending) | ||
| .limit(limit); | ||
|
|
||
| response.json(elves); | ||
|
|
||
| } catch (error) { | ||
| response.status(500).json({ error: "Failed to fetch elves" }); | ||
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
Well done using query params, RESTful 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render link
Project Mongo API feat Elves on Render