Open
Conversation
HIPPIEKICK
approved these changes
Sep 13, 2024
Contributor
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Great work on completing this project! 🎉
JavaScript
- You’re using if-else statements effectively to control the flow based on user input.
- You're using let to declare variables, which is good. It is appropriate for variables whose values change
- You're handling invalid choices nicely in some places but could make this more consistent across the entire code.
- Consider parsing the inputs to be able to determine if the user wrote a number or not. Especially for age where you want the input to be a number to be able to do the checks
- Consider ending the flow if a user types an invalid input. You can do this with the return keyword
Clean Code
- The code is overall clean with consistent indentation
- Be consistent with whether you're using semicolons or not! If you decide to use them, you need to learn where they should go. No mix please!
Keep up the good work Elina, but remember these things going forward ⭐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://elinasjavascriptpizzeria.netlify.app/