Open
Conversation
HIPPIEKICK
approved these changes
Sep 13, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Really nice job on this project Xing!
JavaScript
- Nice to see that you're trying out both the if-else approach as well as the switch approach! However, for the future, the more consistent code, the more clean 😊
- The variable naming (userName, selectedFood, etc.) is clear and descriptive, which makes the code readable.
- The exit(1) is intended for server-side Node.js or environments that support it, but in the browser context, you could use return to exit the current function
Clean Code
- Your well-named variables make the code easier to follow
- Pay attention to consistent indentation and spacing (e.g. see comment in the code). Consistency makes your code more readable and professional.
Overall, you've done a really good job, so keep it up ⭐
| // Your code goes here | ||
| alert( | ||
| `Welcome to our Javascript Pizzeria. Ready to Start? - Click 'OK' to begin.` | ||
| alert ( |
Contributor
There was a problem hiding this comment.
There should be no space between JavaScript methods and their corresponding parentheses. Please go through your whole file and change where it applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://xingspizzeria.netlify.app/