Bella Italia – Order your pizza here#146
Open
HeleneWestrin wants to merge 13 commits intoTechnigo:mainfrom
Open
Bella Italia – Order your pizza here#146HeleneWestrin wants to merge 13 commits intoTechnigo:mainfrom
HeleneWestrin wants to merge 13 commits intoTechnigo:mainfrom
Conversation
HIPPIEKICK
approved these changes
Sep 13, 2024
Contributor
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Wow, nice job with this project 🍕
JavaScript
- Really nice to check for edge cases, like if the user doesn't input a name (if (!userName) { userName = "Anonymous"; }). Great job considering that!
- You've done well using control flow statements like do...while as well as if...else and switch to handle user inputs for food selection ⭐
- In script.js, you're using the .toLowerCase() method to handle user input flexibly when confirming their order. Nice use of string manipulation!
- One suggestion is regarding age validation. In the current code, the check for age doesn't account for invalid (non-number) inputs properly:
let pizzaSize = prompt(`Is the pizza for an adult or a child? Please enter your age.`);
if (Number(pizzaSize) >= 12) {
It would be good to handle cases where the input is not a valid number by adding a check before converting to a number. You could use:
if (!isNaN(pizzaSize) && Number(pizzaSize) >= 12) { ... }
This way, you can avoid invalid entries crashing your logic.
Also, very nice with a start function ⭐ Keep up the good work Helene!
Author
|
Thank you @HIPPIEKICK! 🤗 Ohh, great advice! I will look into fixing that 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://bellaitaliapizzeria.netlify.app/