Skip to content

Project Survey - Daniel Brobäck#442

Open
dannebrob wants to merge 7 commits intoTechnigo:masterfrom
dannebrob:master
Open

Project Survey - Daniel Brobäck#442
dannebrob wants to merge 7 commits intoTechnigo:masterfrom
dannebrob:master

Conversation

@dannebrob
Copy link

Copy link

@code-and-cats code-and-cats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. The survey works well, looks nice and meets the stretch goals. The code is easy to follow and makes sense. I really like the solutions in the code for progressing the stages!
Well done!


return (
<main>
{formStage > 0 && <ProgressBar progress={percent} />}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this percent function, havent seen it before!

<h1>Mentorship Sign Up</h1>
</div>
<div className="image-box">
<picture>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason for calling 2 different pictures instead of resizing?

</button>
)}
<form onSubmit={handleSubmit} required>
{formStage === 0 && (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice solution on progressing the stages!

Restart Form
</button>
)}
<form onSubmit={handleSubmit} required>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool that required works well! But is the "required" here needed as well as the required on the different inputs (for example row 105)? Are they both needed? If yes, what are they doing?

)}
{formStage === 3 && (
<div>
<h1>What time commitment can I make? /Hours a month/ *</h1>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super minor nitpicky thing, the user has been asked stuff as a "you" before this, and now an "I". Might be nice to be consistent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants