Project Survey - Andrea Hedström#458
Project Survey - Andrea Hedström#458AndreaHedstrom wants to merge 21 commits intoTechnigo:masterfrom
Conversation
beemailley
left a comment
beemailley
left a comment
There was a problem hiding this comment.
Overall, everything looks good! Your code looks very clean and very easy to read. The components are easy to understand. Good job!
| </div> | ||
| ); | ||
| } | ||
| }; |
There was a problem hiding this comment.
I like that your App.js is very tidy and organized. It's very easy to see how everything is related.
| margin-left: 25px; | ||
| margin-right: 25px; | ||
| border-radius: 10px; | ||
|
|
There was a problem hiding this comment.
So, I won't comment a ton on your CSS - you've already said you're updating it. But, I wanted to share "vw" and "vh" as measurements for view width and view height. If you've already experimented with these, ignore me. They were new to me as I was styling this project and were SUPER helpful in forcing my survey to take up the amount of space that I wanted it to.
| id="drink" | ||
| value={drink} | ||
| onChange={handleDrinkChange}> | ||
| <option value="">Menu</option> |
There was a problem hiding this comment.
I think you can add "disable" either before or after "value" for the MENU line and that will stop being an acceptable value. Then the user would have to pick something else from the dropdown.
| className="radioBtn" | ||
| value={group} | ||
| onChange={handleFoodChange} | ||
| checked={food === group} /> |
There was a problem hiding this comment.
I think an easy way to add a bit of accessibility is to add an aria-label here. Something like:
aria-label={group}
Then the label should change for each radio button.
| })) | ||
| }}>MAGIC PARTYBUTTON | ||
| </button> | ||
|
|
There was a problem hiding this comment.
The party button is such a cute addition! And I like that the confetti colors match your design scheme.
2 participants
No description provided.