Open
Conversation
HIPPIEKICK
approved these changes
Oct 3, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
HTML/CSS
- Simple and clean HTML file. Consider using semantic elements more and keep the amount of divs down
- I love the quirky design (haha and the name of your page)! However, remember to try to follow our design the next time we tell you to, as it's an important skill to learn.
JavaScript
- Nice to gather all the icons in a variable! Since it's a list however, maybe it would make more sense as an array?
- Your code definitely works like it is now, but going forward I would like you to modularize your code more and break it out into functions.
Clean Code
- Clean up all console.logs, unused code and instructional comments from us.
Keep up the good work Nella!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link:
https://grayslay.netlify.app/