Skip to content

Jonas Weather app#419

Open
Jonash189 wants to merge 5 commits intoTechnigo:masterfrom
Jonash189:master
Open

Jonas Weather app#419
Jonash189 wants to merge 5 commits intoTechnigo:masterfrom
Jonash189:master

Conversation

@Jonash189
Copy link

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML/CSS

  • Good that you're using semantic HTML elements, such as section. Just remember that all HTML elements should be written in lowercase
  • Short and sweet CSS file ⭐

JavaScript

  • Short and sweet JS file as well. Consider creating functions for the different fetches to make it more readable (by giving the functions clear and descriptive names)
  • Consider also creating helper functions for formatting the dates and updating the HTML

Clean Code

  • Change your indentation to be 2 spaces (settings in VS Code)
  • Be consistent with whether or not you're using semicolons. Don't mix!

No changes requested, just keep these things in mind going forward 😊

@HIPPIEKICK HIPPIEKICK self-assigned this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants