Open
Conversation
…icon and display weather of searched city
…er ID and local time
HIPPIEKICK
approved these changes
Oct 3, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
HTML/CSS
- Well structured HTML file! Just remember to put the script within the body. Also, consider using more semantic elements instead of just divs
- Real nice work with copying the design! Love the color overlay!
- Would be super nice if the arrow to change city had a pointer cursor on hover
- Try to keep the JS to the JS file (using event listeners instead of the
onclickmethod)
JavaScript
- Well structured and easy-to-follow JS 👍 A lot of well-named and well-structured functions. The capitalizeFirstLetter function is beautiful!
Clean Code
- Be consistent with if you're using single or double quotes
No changes requested, just keep up the good work! 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://joycekuoweatherapp.netlify.app/