Open
Conversation
JennieDalgren
previously requested changes
Oct 4, 2024
Contributor
JennieDalgren
left a comment
JennieDalgren
left a comment
There was a problem hiding this comment.
You've done a great job with this weather app! 🎉
I feel there are some confusion around the sunrise and sunset happening in the middle of the night. I assume this is based on "Stockholm-time" so the sunrise in Tokyo is 22:38 not local time. It's an interesting approach for the weather app but the UX is very confusing. If you did this intentionally, find a way to make this clear to the user.
HTML/CSS
- Good job with the structure and nice little favicon too.
- Remember that you can always add some comments in the css to make it clearer where you can fins the styling for different sections etc.
JavaScript
- Nice job with the fetching from the API.
- Good structure of you code and functions.
Clean Code
- All your code is easy to follow and have a good structure.
- You are using comments in a goos way in the js file.
- You are naming your functions well.
Changes Requested
Change the time format to show local time for sunrise and sunset - or if you really want to show the times in the format for the user (GMT+2 for us) then find a way to make this clearer.
Keep up the great work, and I look forward to seeing your next project! 😊
HIPPIEKICK
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://mikasweather.netlify.app/