Estefanny's weather app PR

[FannyEste]

Netlify link

https://shiny-sopapillas-ecb62f.netlify.app/

[JennieDalgren]

Good job with this project!

You've nailed most of the functionality that was required this week. However, it seems like the min and max temperatures are showing the same values.
Also I'm wondering what this time (17:40) indicates?

HTML and CSS

• Good use of semantic HTML elements and attributes.
• Consistent use of font families and sizes.
• Proper use of flexbox for layout management.
• Clear separation of styles for different components (search icon, current weather, forecast).

JavaScript

• Good structure and understandable cide

• Proper error handling with try/catch blocks.

• DRY Principle: Refactor to avoid repetition in API URLs.

  const baseUrl = "https://api.openweathermap.org/data/2.5/";
  const city = "Stockholm,Sweden";
  const units = "metric";
  const apiUrl = `${baseUrl}weather?q=${city}&units=${units}&APPID=${apiKey}`;
  const forecastApiUrl = `${baseUrl}forecast?q=${city}&units=${units}&APPID=${apiKey}`;

Things to fix:

• Make sure to be consistent, use single or double quotes throughout the script.
• Check the min max temp data so it shows the correct data

[FannyEste]

Good job with this project!

You've nailed most of the functionality that was required this week. However, it seems like the min and max temperatures are showing the same values. Also I'm wondering what this time (17:40) indicates?

HTML and CSS

• Good use of semantic HTML elements and attributes.
• Consistent use of font families and sizes.
• Proper use of flexbox for layout management.
• Clear separation of styles for different components (search icon, current weather, forecast).

JavaScript

• Good structure and understandable cide
• Proper error handling with try/catch blocks.
• DRY Principle: Refactor to avoid repetition in API URLs.

  const baseUrl = "https://api.openweathermap.org/data/2.5/";
  const city = "Stockholm,Sweden";
  const units = "metric";
  const apiUrl = `${baseUrl}weather?q=${city}&units=${units}&APPID=${apiKey}`;
  const forecastApiUrl = `${baseUrl}forecast?q=${city}&units=${units}&APPID=${apiKey}`;

Things to fix:

• Make sure to be consistent, use single or double quotes throughout the script.
• Check the min max temp data so it shows the correct data

Hi, just to let you know I implemented the requested changes, I was not sure if only implementing was enogh, so Im letting the comment here just in case! thanks

[JennieDalgren]

Approved ⭐