Open
Conversation
JennieDalgren
approved these changes
Oct 7, 2024
Contributor
JennieDalgren
left a comment
JennieDalgren
left a comment
There was a problem hiding this comment.
Good job with this project!
Nice use of some helper functions and adding comments to the code.
It looks like the next step would be to refactor and see if you can find a way to keep your code a bit cleaner using the DRY approach. This is something you will learn with time, just something to reflect on.
Also, avoid naming a variable as specific as you've done with stockholm and stockholmTemp. Even though this project only displays Stockholm weather, try to keep it more generic to make sense if you choose to swap to Tokyo for example.
city and cityTemp might be better names.
Keep it up 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://master--weathertheweatherapp.netlify.app