Accessibility project (Weather app)#436
Open
jempa182 wants to merge 18 commits intoTechnigo:masterfrom
Open
Conversation
HIPPIEKICK
approved these changes
Oct 10, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Good job with the accessibility work! Nice that you’ve implemented some aria labels 🥳 A note about tabindex however, it’s used for interactive elements, but since none of your elements are interactive/clickable, you don’t need tabindex for those. It’s more for, let’s say a hamburger menu that’s in reality a div - for the user to be able to "click it” using keyboard.
Good also that you’ve added alt tags for the icons, I think it’s easy to forget alt tags when you have the HTML in the JS 😅 Keep up the good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://project-weather-a11y--whats-the-weather-jenny.netlify.app/