Skip to content

TD-7444-Moved warning callout partial outside legend tag. #3702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rshrirohit merged 1 commit into from
Jul 23, 2026
Merged

TD-7444-Moved warning callout partial outside legend tag. #3702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions DigitalLearningSolutions.Web/Views/CompetencyAssessments/CompetencyAssessmentOptions.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,15 @@
<div class="nhsuk-form-group">
<fieldset class="nhsuk-fieldset" aria-describedby="example-hints-hint">
<legend class="nhsuk-fieldset__legend nhsuk-fieldset__legend--l">
<h1 class="app-page-heading">
<h1 class="app-page-heading nhsuk-u-margin-bottom-0">
<span class="nhsuk-caption-xl">
@Model.CompetencyAssessmentName
<span class="nhsuk-u-visually-hidden"> – </span>
</span>
Display learner declaration?
</h1>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
</legend>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
<div id="example-hints-hint" class="nhsuk-hint">
Do you want to prompt learners to agree to the self-assessment process when they first start the self-assessment?
</div>
Expand All @@ -119,15 +119,15 @@
<div class="nhsuk-form-group">
<fieldset class="nhsuk-fieldset" aria-describedby="example-hints-hint">
<legend class="nhsuk-fieldset__legend nhsuk-fieldset__legend--l">
<h1 class="app-page-heading">
<h1 class="app-page-heading nhsuk-u-margin-bottom-0">
<span class="nhsuk-caption-xl">
@Model.CompetencyAssessmentName
<span class="nhsuk-u-visually-hidden"> – </span>
</span>
Include signposting?
</h1>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
</legend>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
<div id="example-hints-hint" class="nhsuk-hint">
Do you want to display signposted learning content when a learner submits their self-assessment results?
</div>
Expand All @@ -154,15 +154,15 @@
<div class="nhsuk-form-group">
<fieldset class="nhsuk-fieldset" aria-describedby="example-hints-hint">
<legend class="nhsuk-fieldset__legend nhsuk-fieldset__legend--l">
<h1 class="app-page-heading">
<h1 class="app-page-heading nhsuk-u-margin-bottom-0">
<span class="nhsuk-caption-xl">
@Model.CompetencyAssessmentName
<span class="nhsuk-u-visually-hidden"> – </span>
</span>
Use linear navigation?
</h1>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
</legend>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
<div id="example-hints-hint" class="nhsuk-hint">
Do you want the learner to work through @Model.VocabularyPlural.ToLower() using next and previous links? If not, the learner will navigate between @Model.VocabularyPlural.ToLower() using the @Model.VocabularySingular.ToLower() menu.
</div>
Expand All @@ -189,15 +189,15 @@
<div class="nhsuk-form-group">
<fieldset class="nhsuk-fieldset" aria-describedby="example-hints-hint">
<legend class="nhsuk-fieldset__legend nhsuk-fieldset__legend--l">
<h1 class="app-page-heading">
<h1 class="app-page-heading nhsuk-u-margin-bottom-0">
<span class="nhsuk-caption-xl">
@Model.CompetencyAssessmentName
<span class="nhsuk-u-visually-hidden"> – </span>
</span>
Use description expanders?
</h1>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
</legend>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
<div id="example-hints-hint" class="nhsuk-hint">
Do you want to show @Model.VocabularySingular.ToLower() descriptions using expanders? If not, the description will be displayed on the page without the user needing to expand it.
</div>
Expand All @@ -224,15 +224,15 @@
<div class="nhsuk-form-group">
<fieldset class="nhsuk-fieldset" aria-describedby="example-hints-hint">
<legend class="nhsuk-fieldset__legend nhsuk-fieldset__legend--l">
<h1 class="app-page-heading">
<h1 class="app-page-heading nhsuk-u-margin-bottom-0">
<span class="nhsuk-caption-xl">
@Model.CompetencyAssessmentName
<span class="nhsuk-u-visually-hidden"> – </span>
</span>
Custom question label
</h1>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
</legend>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
<div id="example-hints-hint" class="nhsuk-hint">
Do you want to specify a custom label for self-assessment questions? If not, they will be labelled as “question”.
</div>
Expand Down Expand Up @@ -271,15 +271,15 @@
<div class="nhsuk-form-group">
<fieldset class="nhsuk-fieldset" aria-describedby="example-hints-hint">
<legend class="nhsuk-fieldset__legend nhsuk-fieldset__legend--l">
<h1 class="app-page-heading">
<h1 class="app-page-heading nhsuk-u-margin-bottom-0">
<span class="nhsuk-caption-xl">
@Model.CompetencyAssessmentName
<span class="nhsuk-u-visually-hidden"> – </span>
</span>
Reviewer comments label
</h1>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
</legend>
<partial name="Shared/_PublishedSelfAssessmentWarning" model="new PublishedSelfAssessmentViewModel { UserRole = Model.UserRole, PublishStatusID = Model.PublishStatusID }" />
<div id="example-hints-hint" class="nhsuk-hint">
Do you want to specify a custom supervisor comments prompt? If not, they will be labelled as “Reviewer comments”.
</div>
Expand Down
Loading