Skip to content

TD-7590 Optimise GetAssessmentResultByDelegate #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rshrirohit merged 2 commits into from
Aug 21, 2026
Merged

TD-7590 Optimise GetAssessmentResultByDelegate #3739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfff5c2
TD-7590 Optimise GetAssessmentResultByDelegate
rshrirohit Aug 12, 2026
147e307
Merge branch 'DLS-Release-v1.3.3' into Develop/Fixes/TD-7590-Optimise…
rshrirohit Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 123 additions & 0 deletions DigitalLearningSolutions.Data.Migrations/202608122218_Alter_GetAssessmentResultByDelegate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
namespace DigitalLearningSolutions.Data.Migrations
{
using FluentMigrator;
using FluentMigrator.SqlServer;

[Migration(202608122218)]
public class Alter_GetAssessmentResultByDelegate : Migration
{
public override void Up()
{
Create.Index("IX_SelfAssessmentResults_Assessment_Delegate_Question")
.OnTable("SelfAssessmentResults")
.OnColumn("SelfAssessmentID").Ascending()
.OnColumn("DelegateUserID").Ascending()
.OnColumn("CompetencyID").Ascending()
.OnColumn("AssessmentQuestionID").Ascending()
.WithOptions()
.NonClustered()
.Include("ID")
.Include("DateTime")
.Include("Result")
.Include("SupportingComments");

Create.Index("IX_CandidateAssessments_Active_Assessment_Delegate")
.OnTable("CandidateAssessments")
.OnColumn("SelfAssessmentID").Ascending()
.OnColumn("DelegateUserID").Ascending()
.WithOptions()
.NonClustered()
.Include("ID");

//Execute.Sql(@"CREATE NONCLUSTERED INDEX IX_CandidateAssessments_Active_Assessment_Delegate ON CandidateAssessments (SelfAssessmentID, DelegateUserID) INCLUDE (ID) WHERE RemovedDate IS NULL;");

Create.Index("IX_SelfAssessmentStructure_Assessment_Competency")
.OnTable("SelfAssessmentStructure")
.OnColumn("SelfAssessmentID").Ascending()
.OnColumn("CompetencyID").Ascending()
.WithOptions()
.NonClustered()
.Include("CompetencyGroupID")
.Include("Ordering")
.Include("Optional");

Create.Index("IX_CompetencyAssessmentQuestions_Competency_Question")
.OnTable("CompetencyAssessmentQuestions")
.OnColumn("CompetencyID").Ascending()
.OnColumn("AssessmentQuestionID").Ascending()
.WithOptions()
.NonClustered()
.Include("Ordering")
.Include("Required");

Create.Index("IX_CandidateAssessmentOptionalCompetencies_Lookup")
.OnTable("CandidateAssessmentOptionalCompetencies")
.OnColumn("CandidateAssessmentID").Ascending()
.OnColumn("CompetencyID").Ascending()
.OnColumn("CompetencyGroupID").Ascending()
.WithOptions()
.NonClustered()
.Include("IncludedInSelfAssessment");

Create.Index("IX_SelfAssessmentResultSupervisorVerifications_Result_Active")
.OnTable("SelfAssessmentResultSupervisorVerifications")
.OnColumn("SelfAssessmentResultId").Ascending()
.OnColumn("Superceded").Ascending()
.WithOptions()
.NonClustered()
.Include("ID")
.Include("Requested")
.Include("Verified")
.Include("Comments")
.Include("SignedOff")
.Include("CandidateAssessmentSupervisorID");

Create.Index("IX_CompetencyAssessmentQuestionRoleRequirements_ResultRag")
.OnTable("CompetencyAssessmentQuestionRoleRequirements")
.OnColumn("SelfAssessmentID").Ascending()
.OnColumn("CompetencyID").Ascending()
.OnColumn("AssessmentQuestionID").Ascending()
.OnColumn("LevelValue").Ascending()
.WithOptions()
.NonClustered()
.Include("LevelRAG");

Create.Index("IX_FrameworkCompetencies_Competency_Framework")
.OnTable("FrameworkCompetencies")
.OnColumn("CompetencyID").Ascending()
.OnColumn("FrameworkID").Ascending()
.WithOptions()
.NonClustered();

Execute.Sql(Properties.Resources.TD_7590_Alter_GetAssessmentResultByDelegate_Up);
}
public override void Down()
{
Delete.Index("IX_SelfAssessmentResults_Assessment_Delegate_Question")
.OnTable("SelfAssessmentResults");

Delete.Index("IX_CandidateAssessments_Active_Assessment_Delegate")
.OnTable("CandidateAssessments");

Delete.Index("IX_SelfAssessmentStructure_Assessment_Competency")
.OnTable("SelfAssessmentStructure");

Delete.Index("IX_CompetencyAssessmentQuestions_Competency_Question")
.OnTable("CompetencyAssessmentQuestions");

Delete.Index("IX_CandidateAssessmentOptionalCompetencies_Lookup")
.OnTable("CandidateAssessmentOptionalCompetencies");

Delete.Index("IX_SelfAssessmentResultSupervisorVerifications_Result_Active")
.OnTable("SelfAssessmentResultSupervisorVerifications");

Delete.Index("IX_CompetencyAssessmentQuestionRoleRequirements_ResultRag")
.OnTable("CompetencyAssessmentQuestionRoleRequirements");

Delete.Index("IX_FrameworkCompetencies_Competency_Framework")
.OnTable("FrameworkCompetencies");

Execute.Sql(Properties.Resources.TD_7590_Alter_GetAssessmentResultByDelegate_Down);
}
}
}
46 changes: 46 additions & 0 deletions DigitalLearningSolutions.Data.Migrations/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion DigitalLearningSolutions.Data.Migrations/Properties/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,12 @@
<data name="TD_7592_Alter_GetNotificationsForAdminUser_Up" type="System.Resources.ResXFileRef, System.Windows.Forms">
<value>..\Scripts\TD-7592-Alter_GetNotificationsForAdminUser_Up.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-16</value>
</data>
<data name="TD_7590_Alter_GetAssessmentResultByDelegate_Down" type="System.Resources.ResXFileRef, System.Windows.Forms">
<value>..\Scripts\TD-7592-Alter_GetNotificationsForAdminUser_Down.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-16</value>
</data>
<data name="TD_7590_Alter_GetAssessmentResultByDelegate_Up" type="System.Resources.ResXFileRef, System.Windows.Forms">
<value>..\Scripts\TD-7592-Alter_GetNotificationsForAdminUser_Up.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-16</value>
</data>
<data name="TD_7640_Alter_usp_GetSelfAssessmentReport_Down" type="System.Resources.ResXFileRef, System.Windows.Forms">
<value>..\Scripts\TD-7640-Alter_usp_GetSelfAssessmentReport_Down.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-16</value>
</data>
Expand All @@ -571,4 +577,4 @@
<data name="TD_7598_Alter_GetCompletedCoursesForCandidate_Up" type="System.Resources.ResXFileRef, System.Windows.Forms">
<value>..\Resources\TD_7598_Alter_GetCompletedCoursesForCandidate_Up.sql;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;utf-8</value>
</data>
</root>
</root>
Binary file added ...ingSolutions.Data.Migrations/Scripts/TD-7590-Alter_GetAssessmentResultByDelegate_Down.sql
View file
Open in desktop
Binary file not shown.
Binary file added ...ningSolutions.Data.Migrations/Scripts/TD-7590-Alter_GetAssessmentResultByDelegater_Up.sql
View file
Open in desktop
Binary file not shown.
Loading