Skip to content

Correct autocomplete references in alignment to HTML best practices - #4

Closed
akdalin-hee wants to merge 21 commits into
releases/phoenixfrom
TD-3158-mylearning-accessibility-fix
Closed

Correct autocomplete references in alignment to HTML best practices#4
akdalin-hee wants to merge 21 commits into
releases/phoenixfrom
TD-3158-mylearning-accessibility-fix

Conversation

@akdalin-hee

Copy link
Copy Markdown
Contributor

JIRA link

TD-3158

Description

Correct autocomplete references in alignment to HTML best practices.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@akdalin-hee
akdalin-hee changed the base branch from master to releases/phoenix January 18, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants