Skip to content

update the check_list to use set and add message #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update the check_list to use set and add message #42

wants to merge 1 commit into from

Conversation

@denini08
Copy link

This PR updates the check_list function in test_utils.py to:

  • use set for faster lookups.
  • add error message in assertion

This makes the tests a bit more efficient and adds clear messages.

@denini08 denini08 changed the title update the check_list to use set and message update the check_list to use set and add message May 17, 2025
lucferbux
lucferbux approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lucferbux lucferbux lucferbux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@denini08 @lucferbux