Skip to content

Conversation

@ruben-garciad
Copy link
Contributor

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

  • Upgrade go version from 1.23 to 1.25
  • Upggrade direct dependencies
  • Review code analysis workflow

@ruben-garciad ruben-garciad self-assigned this Oct 2, 2025
@ruben-garciad ruben-garciad added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Oct 2, 2025
@ruben-garciad
Copy link
Contributor Author

ruben-garciad commented Oct 3, 2025

CI workflow fails after upgrading actions/setup-go from v4 to v6. The problem was that in version v4, even though attempts were made to force the use of a specific version, it always ended up using the version defined in the repository:

  • actions/setup-go@v4
Captura de pantalla 2025-10-03 130941
  • actions/setup-go@v6
Captura de pantalla 2025-10-03 130905

In fact, it didn't make much sense to define a version with the go directive in the go.mod file and then try to compile it with an older version.

What might make sense would be to define a minimum version and try to compile the code with later versions without exceeding the one indicated in the toolchain directive of the go.mod file.

Copy link
Member

@mariolg mariolg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariolg mariolg merged commit dc5b538 into master Oct 16, 2025
3 checks passed
@ruben-garciad ruben-garciad deleted the chore/HDNS-11732-Upgrade_go_version_to_1.25 branch October 20, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants