Skip to content

Fix marker callback global issue#69

Merged
cusspvz merged 1 commit intoTelerik-Verified-Plugins:masterfrom
cusspvz:fix/marker-callback-issue
Sep 21, 2017
Merged

Fix marker callback global issue#69
cusspvz merged 1 commit intoTelerik-Verified-Plugins:masterfrom
cusspvz:fix/marker-callback-issue

Conversation

@cusspvz
Copy link
Contributor

@cusspvz cusspvz commented Dec 31, 2016

Fixes issue described by me at #67

It happened with me, since markerCallback does sit under a global space instead of a map instance, it will sit there until we change. I have two kinds of maps on the project I'm using it. The first one does have markers and I need the callback for navigation. The second one is a location dragger, it has only one map, you move the map anywhere, it places the marker always in the middle (since we don't have dragged markers) and this allows me to give the user a way to choose a location. The issue was, whenever an user clicked on the second map's marker, it tried to execute things from the first one. I've workaround it by placing a noop js function () => {} whenever the first map was destroyed. The solution is to keep callbacks only during while the map view is opened.

@cusspvz cusspvz merged commit 2d26122 into Telerik-Verified-Plugins:master Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant