fix enum desrialization in GetProperty

Terradue · Sep 17, 2021 · 079b4b7 · 079b4b7
1 parent d9cad04
commit 079b4b7
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -12,9 +12,9 @@
 
 <h3 align="center">
 
-![Build Status](https://github.com/Terradue/DotNetStac/actions/workflows/build.yaml/badge.svg?branch=hotfix/1.1.2-1)
+![Build Status](https://github.com/Terradue/DotNetStac/actions/workflows/build.yaml/badge.svg?branch=hotfix/1.1.3)
 [![NuGet](https://img.shields.io/nuget/vpre/DotNetStac)](https://www.nuget.org/packages/DotNetStac/)
-[![codecov](https://codecov.io/gh/Terradue/DotNetStac/branch/hotfix/1.1.2-1/graph/badge.svg)](https://codecov.io/gh/Terradue/DotNetStac)
+[![codecov](https://codecov.io/gh/Terradue/DotNetStac/branch/hotfix/1.1.3/graph/badge.svg)](https://codecov.io/gh/Terradue/DotNetStac)
 [![Gitter](https://img.shields.io/gitter/room/SpatioTemporal-Asset-Catalog/Lobby?color=yellow)](https://gitter.im/SpatioTemporal-Asset-Catalog/Lobby)
 [![License](https://img.shields.io/badge/license-AGPL3-blue.svg)](LICENSE)
 [![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/Terradue/DotNetStac/master?filepath=example.ipynb)

diff --git a/src/DotNetStac.Test/Common/StacAccessorsHelpersTests.cs b/src/DotNetStac.Test/Common/StacAccessorsHelpersTests.cs
@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using GeoJSON.Net.Geometry;
+using Stac.Collection;
 using Stac.Common;
 using Xunit;
 
@@ -48,6 +49,25 @@ public void GetPropertyTest()
 
             Assert.Equal(dataType, item.GetProperty<DataType?>("test"));
 
+
+            SummaryItemType summaryItemType = default(SummaryItemType);
+
+            item.SetProperty("summary", summaryItemType);
+
+            Assert.NotNull(item.GetProperty<SummaryItemType>("summary"));
+
+            summaryItemType = SummaryItemType.RangeObject;
+
+            item.SetProperty("summary", summaryItemType);
+
+            Assert.Equal(summaryItemType, item.GetProperty<SummaryItemType>("summary"));
+
+            itemJson = StacConvert.Serialize(item);
+
+            item = StacConvert.Deserialize<StacItem>(itemJson);
+
+            Assert.Equal(summaryItemType, item.GetProperty<SummaryItemType>("summary"));
+
         }
     }
 }
diff --git a/src/DotNetStac/StacAccessorsHelpers.cs b/src/DotNetStac/StacAccessorsHelpers.cs
@@ -57,9 +57,9 @@ public static T GetProperty<T>(this IDictionary<string, object> properties, stri
             if (t.IsGenericType && t.GetGenericTypeDefinition().Equals(typeof(Nullable<>)))
             {
                 t = Nullable.GetUnderlyingType(t);
-                if (t.GetTypeInfo().IsEnum)
-                    return (T)Enum.Parse(t, @object.ToString());
             }
+             if (t.GetTypeInfo().IsEnum)
+                    return (T)Enum.Parse(t, @object.ToString());
             return ChangeType<T>(@object);
         }