update idoft #1353
Merged
update idoft #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make the checker pass |
|
fixed a new flacky test and updated other changes in status for this week and last week |
pr-data.csv
Outdated
| @@ -4050,6 +4050,7 @@ https://github.com/fluent/fluent-logger-java,da14ec349bf0904da9865940b57b8756361 | |||
| https://github.com/fluent/fluent-logger-java,da14ec349bf0904da9865940b57b87563616ee04,.,org.fluentd.logger.TestFluentLogger.testReconnection,NDOD;UD;NOD,Unmaintained,,last commit on 2019-06-12 | |||
| https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-engine,net.redpipe.engine.swagger.SwaggerApiTest.checkSwagger,NOD,RepoArchived,, | |||
| https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-templating-freemarker,net.redpipe.templating.freemarker.ApiTest.checkMail,NOD,RepoArchived,, | |||
| https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-templating-freemarker,net.redpipe.templating.freemarker.ApiTest.checkTemplateNegociationDefault,ID,DeveloperFixed,https://github.com/FroMage/redpipe/commit/2fc605bc2fad4aadbb3b05282f528a05673df2ca#diff-86139da6bd888a5e7589f89d4f81a426bac99cd8aabab363efb5e338c1158f5bR131, | |||
| https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-templating-freemarker,net.redpipe.templating.freemarker.ApiTest.checkTemplateNegociationDefault,ID,Opened,https://github.com/fromage/redpipe/pull/56, | |||
There was a problem hiding this comment.
Where is the evidence (logs) for the claim that this PR fixed this test?
pr-data.csv
Outdated
| @@ -4735,6 +4736,7 @@ https://github.com/jenkinsci/jenkins,d2fa87606246e1f1dc1450d7199778343945197e,te | |||
| https://github.com/jenkinsci/jenkins,d2fa87606246e1f1dc1450d7199778343945197e,test,lib.layout.IconTest.testBallColorTd,ID,,, | |||
| https://github.com/jenkinsci/jenkins,d2fa87606246e1f1dc1450d7199778343945197e,test,lib.layout.IconTest.testTasks,ID,DeveloperFixed,,https://github.com/jenkinsci/jenkins/commit/81072df4f7f3c0ecef0d5ab20100a87cb0acce58 | |||
| https://github.com/jenkinsci/remoting,abf0455a68ad6c52a57e912bb89d51f883f77542,.,hudson.remoting.ClassFilterTest.capabilityRead,OD,,,https://github.com/TestingResearchIllinois/flaky-test-dataset/issues/82 | |||
| https://github.com/jenkinsci/remoting,abf0455a68ad6c52a57e912bb89d51f883f77542,.,hudson.remoting.ClassFilterTest.capabilityRead,OD,DeveloperFixed,,https://github.com/jenkinsci/remoting/commit/26e24490f041ef423cbe1c94b262983790613fbd#diff-ee56285c19352719bba4df32d1496b4c9d9f11c34062a587815d0e1b041b66df | |||
There was a problem hiding this comment.
Where is the evidence (logs) for the claim that this PR fixed this test?
Please update the previous row (by adding your link into the last column separated with ; from the existing ..../issues/82).
pr-data.csv
Outdated
| @@ -5515,8 +5517,10 @@ https://github.com/ripe-ncc/whois,79e90f41d7eeee42f2c3ad299bfccc4e8005ce8c,whois | |||
| https://github.com/ripe-ncc/whois,79e90f41d7eeee42f2c3ad299bfccc4e8005ce8c,whois-endtoend,net.ripe.db.whois.spec.domain.AckResponseTest.successes,UD,,, | |||
| https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteConsole,ID,Opened,https://github.com/robovm/robovm/pull/1272, | |||
| https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteConsole,ID,Opened,https://github.com/robovm/robovm/pull/1274, | |||
| https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteConsole,ID,Opened,https://github.com/robovm/robovm/pull/1276, | |||
There was a problem hiding this comment.
Your PR 1276 seems to be a duplicate of 1274 (and 1272)! Please close your PR 1276 and remove these lines.
pr-data.csv
Outdated
| @@ -6627,9 +6631,9 @@ https://github.com/zalando/riptide,dcf4af17abfd312243897e79e0577d1e28537e7d,ript | |||
| https://github.com/zalando/riptide,dcf4af17abfd312243897e79e0577d1e28537e7d,riptide-spring-boot-autoconfigure,org.zalando.riptide.autoconfigure.AsyncClientHttpRequestFactoryTest.shouldAutowireAsync,UD,Deleted,,https://github.com/zalando/riptide/commit/3f698fad27f92d7b0df0240d0d5343bb3e293b4b#diff-93984af22d3eb64d6de9635a3c47ef64cac7e7ed745342dae2a823897fd31750 | |||
| https://github.com/zalando/riptide,dcf4af17abfd312243897e79e0577d1e28537e7d,riptide-spring-boot-autoconfigure,org.zalando.riptide.autoconfigure.AsyncClientHttpRequestFactoryTest.shouldAutowireSync,UD,Deleted,,https://github.com/zalando/riptide/commit/3f698fad27f92d7b0df0240d0d5343bb3e293b4b#diff-93984af22d3eb64d6de9635a3c47ef64cac7e7ed745342dae2a823897fd31750 | |||
| https://github.com/zalando/riptide,dcf4af17abfd312243897e79e0577d1e28537e7d,riptide-spring-boot-autoconfigure,org.zalando.riptide.autoconfigure.CircuitBreakerTest.shouldAutowireCircuitBreakers,NOD,,, | |||
| https://github.com/zalando/riptide,dcf4af17abfd312243897e79e0577d1e28537e7d,riptide-spring-boot-autoconfigure,org.zalando.riptide.autoconfigure.ClientConfigurationTest.shouldApplyTimeouts,NOD,,, | |||
| https://github.com/zalando/riptide,dcf4af17abfd312243897e79e0577d1e28537e7d,riptide-spring-boot-autoconfigure,org.zalando.riptide.autoconfigure.ClientConfigurationTest.shouldApplyTimeouts,NOD,DeveloperFixed,,https://github.com/zalando/riptide/commit/7374312bfaec5277302d9cd5627e9c477b45e7f6#diff-3a5c9d71b943a3c0b0f272cee25211205cf4ed1f0dbe7301c442f77b02097071R71 | |||
There was a problem hiding this comment.
Where is the evidence (logs) for the claim that this PR fixed this test?
|
I'm still waiting for a reply here. We can close this PR for negative "points", or you can provide more info (especially logs). You also need to rebase your changes on the latest |
|
You still need to respond to this PR if you want to get some "points". |
|
I rechecked all these issues in week4, corrected some of my false status changes, and add all the log files required, which are recorded in progress_4.md. Please refer to PR #1464 to see the changes. I directly opened another PR and abandoned this one. （For the latest version that rebased on latest main, see #1597) |
|
Please revise this PR instead of "abandoning" it. Just keep the few lines you want to change but rebase your work on the latest |
|
I revised the changes here, since in later weeks I found some of this week's change was problematic, which I deleted, and the rest of the issues were fixed in #1464. To avoid duplicate changes with PR 1464, I just removed the lines of PR 1276 here. |
|
This PR is ready to accept as soon as you squash the two commits into one. If you want some more "points" about this, you should check all cases where the same test is repeated: |
revised removed all repeated cases
|
I found 8 repeated cases in pr-data.csv: I removed all the second one for repeated cases. |
darko-marinov
requested changes
Dec 21, 2024
| @@ -5038,11 +5038,8 @@ https://github.com/kagkarlsson/db-scheduler,4a8a28e60640dcd03e8d3bf212f483d35b0b | |||
| https://github.com/kal-an/file-reader-app,ba6af3f33000ff1fcde9338922e55a7b1c374f99,.,ru.kalan.filereaderapp.MultiPartParserTest.createBook_ok,ID,Opened,https://github.com/kal-an/file-reader-app/pull/1, | |||
| https://github.com/kanwangzjm/funiture,71ca0fb0658b3d839d9e049ac36429207f05329b,.,com.app.mvc.dao.ShortUrlDaoTest.testSave,NIO,Opened,https://github.com/kanwangzjm/funiture/pull/51,https://github.com/kanwangzjm/funiture/issues/50 | |||
| https://github.com/karatelabs/karate,16452ef4d17ed76b079c6f1eba07a4749fa08d02,karate-core,com.intuit.karate.core.FeatureResultTest.testJsonConversion,ID,DeveloperWontFix,, | |||
| https://github.com/karatelabs/karate,2c42468d5f32cb32592ad4a46bcf5ff1a4e60a5e,karate-core,com.intuit.karate.core.FeatureResultTest.testJsonConversion,ID,DeveloperWontFix,, | |||
There was a problem hiding this comment.
Fine to remove one or the other of these two rows as they just repeat the same info. How did you decide whether to remove 16452ef4d17ed76b079c6f1eba07a4749fa08d02 or 2c42468d5f32cb32592ad4a46bcf5ff1a4e60a5e? Presumably we want to remove the later commit and keep the earlier one.
| https://github.com/karatelabs/karate,16452ef4d17ed76b079c6f1eba07a4749fa08d02,karate-core,com.intuit.karate.core.KarateHttpMockHandlerTest.testMultipleCookies,ID,Rejected,https://github.com/karatelabs/karate/pull/1856, | ||
| https://github.com/karatelabs/karate,2c42468d5f32cb32592ad4a46bcf5ff1a4e60a5e,karate-core,com.intuit.karate.core.KarateHttpMockHandlerTest.testMultipleCookies,ID,Rejected,https://github.com/karatelabs/karate/pull/2348, |
There was a problem hiding this comment.
Do not remove this row as the overall info differs from the previous (showing two rejected PRs).
| https://github.com/karatelabs/karate,16452ef4d17ed76b079c6f1eba07a4749fa08d02,karate-core,com.intuit.karate.core.parser.FeatureParserTest.testEngineForSimpleFeature,ID,DeveloperWontFix,, | ||
| https://github.com/karatelabs/karate,2c42468d5f32cb32592ad4a46bcf5ff1a4e60a5e,karate-core,com.intuit.karate.core.parser.FeatureParserTest.testEngineForSimpleFeature,ID,DeveloperWontFix,, |
There was a problem hiding this comment.
Same comment as above about removing 16452ef4d17ed76b079c6f1eba07a4749fa08d02 or 2c42468d5f32cb32592ad4a46bcf5ff1a4e60a5e -- which to remove and which to keep?
pr-data.csv
Outdated
| @@ -5945,9 +5942,7 @@ https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566 | |||
| https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566390a,core,com.pholser.junit.quickcheck.ExhaustingAGivenSetButIncludingAnotherTest.explicitConversion,NIO,Accepted,https://github.com/pholser/junit-quickcheck/pull/357, | |||
| https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566390a,core,com.pholser.junit.quickcheck.ExhaustingAGivenSetButIncludingAnotherTest.favorValueOf,NIO,Accepted,https://github.com/pholser/junit-quickcheck/pull/361, | |||
| https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566390a,core,com.pholser.junit.quickcheck.ExhaustingAGivenSetButIncludingAnotherTest.manyParameters,ID;NIO,Accepted,https://github.com/pholser/junit-quickcheck/pull/284, | |||
| https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566390a,core,com.pholser.junit.quickcheck.ExhaustingAGivenSetButIncludingAnotherTest.manyParameters,ID;NIO,Accepted,https://github.com/pholser/junit-quickcheck/pull/357, | |||
There was a problem hiding this comment.
Do not delete this row as some info (PR number/link) differs.
pr-data.csv
Outdated
| https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566390a,core,com.pholser.junit.quickcheck.ExhaustingAGivenSetButIncludingAnotherTest.manyParametersWithBooleanAndEnum,ID;NIO,Accepted,https://github.com/pholser/junit-quickcheck/pull/284, | ||
| https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566390a,core,com.pholser.junit.quickcheck.ExhaustingAGivenSetButIncludingAnotherTest.manyParametersWithBooleanAndEnum,ID;NIO,Accepted,https://github.com/pholser/junit-quickcheck/pull/357, |
There was a problem hiding this comment.
Do not delete this row as some info (PR number/link) differs.
pr-data.csv
Outdated
| @@ -5972,7 +5967,6 @@ https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566 | |||
| https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566390a,core,com.pholser.junit.quickcheck.ExhaustingAGivenSetTest.explicitConversion,NIO,Accepted,https://github.com/pholser/junit-quickcheck/pull/293, | |||
| https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566390a,core,com.pholser.junit.quickcheck.ExhaustingAGivenSetTest.favorValueOf,NIO,Accepted,https://github.com/pholser/junit-quickcheck/pull/293, | |||
| https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566390a,core,com.pholser.junit.quickcheck.ExhaustingAGivenSetTest.manyParameters,ID;NIO,Accepted,https://github.com/pholser/junit-quickcheck/pull/284, | |||
| https://github.com/pholser/junit-quickcheck,9361b6dae25b193782604d071754eb7fc566390a,core,com.pholser.junit.quickcheck.ExhaustingAGivenSetTest.manyParameters,ID;NIO,Accepted,https://github.com/pholser/junit-quickcheck/pull/361, | |||
There was a problem hiding this comment.
Do not delete this row as some info (PR number/link) differs.
| @@ -6157,10 +6151,7 @@ https://github.com/ripe-ncc/whois,79e90f41d7eeee42f2c3ad299bfccc4e8005ce8c,whois | |||
| https://github.com/ripe-ncc/whois,79e90f41d7eeee42f2c3ad299bfccc4e8005ce8c,whois-api,net.ripe.db.whois.api.rdap.RdapResponseJsonTest.nameserver_serialization_test,ID,Accepted,https://github.com/RIPE-NCC/whois/pull/1097, | |||
| https://github.com/ripe-ncc/whois,79e90f41d7eeee42f2c3ad299bfccc4e8005ce8c,whois-endtoend,net.ripe.db.whois.spec.domain.AckResponseTest.successes,UD,,, | |||
| https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteConsole,ID,Opened,https://github.com/robovm/robovm/pull/1272, | |||
| https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteConsole,ID,Opened,https://github.com/robovm/robovm/pull/1274, | |||
There was a problem hiding this comment.
Add robovm/robovm#1274 and robovm/robovm#1276 into Notes for robovm/robovm#1272
| https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteIOS,ID,Opened,https://github.com/robovm/robovm/pull/1272, | ||
| https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteIOS,ID,Opened,https://github.com/robovm/robovm/pull/1274, |
There was a problem hiding this comment.
Add robovm/robovm#1274 into Notes for robovm/robovm#1272
|
I added those line back, and for the decision between 16452ef4d17ed76b079c6f1eba07a4749fa08d02 and 2c42468d5f32cb32592ad4a46bcf5ff1a4e60a5e, I indeed decided to keep the earlier one and remove the later one, aligning to the similar case of robovm/robovm#1272, robovm/robovm#1274, robovm/robovm#1276, where PR 1272 is the earliest commit so we keep that one. |
|
PR 1272 is clearly earlier than PR 1274 or 1276, because we can just compare the numbers. For commit SHAs, such as 16452ef4d17ed76b079c6f1eba07a4749fa08d02 and 2c42468d5f32cb32592ad4a46bcf5ff1a4e60a5e, it's hard to tell which is earlier unless mapping to the date. What were their dates? |
|
16452ef4d17ed76b079c6f1eba07a4749fa08d02 was on Nov 26, 2021, and 2c42468d5f32cb32592ad4a46bcf5ff1a4e60a5e was on Jan 27, 2023. |
| https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteIOS,ID,Opened,https://github.com/robovm/robovm/pull/1272, | ||
| https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteIOS,ID,Opened,https://github.com/robovm/robovm/pull/1274, | ||
| https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteConsole,ID,Opened,https://github.com/robovm/robovm/pull/1272,https://github.com/robovm/robovm/pull/1274 https://github.com/robovm/robovm/pull/1276 | ||
| https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteIOS,ID,Opened,https://github.com/robovm/robovm/pull/1272,https://github.com/robovm/robovm/pull/1274 https://github.com/robovm/robovm/pull/1276 |
There was a problem hiding this comment.
Was 1276 for ConfigTest.testWriteIOS as well as for ConfigTest.testWriteConsole, or was it only for the latter?
|
It's for both of them. I fixed two tests in PR 1276. There's 2 commits.
获取 Outlook for Android<https://aka.ms/ghei36>
________________________________
From: darko-marinov ***@***.***>
Sent: Sunday, December 22, 2024 12:47:45 AM
To: TestingResearchIllinois/idoft ***@***.***>
Cc: Lyu, Xinying ***@***.***>; Author ***@***.***>
Subject: Re: [TestingResearchIllinois/idoft] update idoft (PR #1353)
@darko-marinov commented on this pull request.
________________________________
In pr-data.csv<https://urldefense.com/v3/__https://github.com/TestingResearchIllinois/idoft/pull/1353*discussion_r1894793178__;Iw!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYaiDpsVDS$>:
RIPE-NCC/whois#1097<https://urldefense.com/v3/__https://github.com/ripe-ncc/whois,79e90f41d7eeee42f2c3ad299bfccc4e8005ce8c,whois-api,net.ripe.db.whois.api.rdap.RdapResponseJsonTest.ip_serialization_test,ID,Accepted,https:/*github.com/RIPE-NCC/whois/pull/1097__;Lw!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYarrKE6lR$>,
RIPE-NCC/whois#1097<https://urldefense.com/v3/__https://github.com/ripe-ncc/whois,79e90f41d7eeee42f2c3ad299bfccc4e8005ce8c,whois-api,net.ripe.db.whois.api.rdap.RdapResponseJsonTest.nameserver_serialization_test,ID,Accepted,https:/*github.com/RIPE-NCC/whois/pull/1097__;Lw!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYaiEKWKHm$>,
https://github.com/ripe-ncc/whois,79e90f41d7eeee42f2c3ad299bfccc4e8005ce8c,whois-endtoend,net.ripe.db.whois.spec.domain.AckResponseTest.successes,UD<https://urldefense.com/v3/__https://github.com/ripe-ncc/whois,79e90f41d7eeee42f2c3ad299bfccc4e8005ce8c,whois-endtoend,net.ripe.db.whois.spec.domain.AckResponseTest.successes,UD__;!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYaomg0xwB$>,,,
-robovm/robovm#1272<https://urldefense.com/v3/__https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteConsole,ID,Opened,https:/*github.com/robovm/robovm/pull/1272__;Lw!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYarKwobmW$>,
-robovm/robovm#1274<https://urldefense.com/v3/__https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteConsole,ID,Opened,https:/*github.com/robovm/robovm/pull/1274__;Lw!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYajd2isaa$>,
-robovm/robovm#1276<https://urldefense.com/v3/__https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteConsole,ID,Opened,https:/*github.com/robovm/robovm/pull/1276__;Lw!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYaq49D0CK$>,
-robovm/robovm#1272<https://urldefense.com/v3/__https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteIOS,ID,Opened,https:/*github.com/robovm/robovm/pull/1272__;Lw!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYamXhHQH4$>,
-robovm/robovm#1274<https://urldefense.com/v3/__https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteIOS,ID,Opened,https:/*github.com/robovm/robovm/pull/1274__;Lw!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYagyEL1_o$>,
+robovm/robovm#1272,https://github.com/robovm/robovm/pull/1274<https://urldefense.com/v3/__https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteConsole,ID,Opened,https:/*github.com/robovm/robovm/pull/1272,https:/*github.com/robovm/robovm/pull/1274__;Ly8!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYamxInAuV$> robovm/robovm#1276<https://urldefense.com/v3/__https://github.com/robovm/robovm/pull/1276__;!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYarnfeaEq$>
+robovm/robovm#1272,https://github.com/robovm/robovm/pull/1274<https://urldefense.com/v3/__https://github.com/robovm/robovm,ef091902377c00dc0fb2db87e8d79c8afb5e9010,compiler,org.robovm.compiler.config.ConfigTest.testWriteIOS,ID,Opened,https:/*github.com/robovm/robovm/pull/1272,https:/*github.com/robovm/robovm/pull/1274__;Ly8!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYat-mdUeM$> robovm/robovm#1276<https://urldefense.com/v3/__https://github.com/robovm/robovm/pull/1276__;!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYarnfeaEq$>
Was 1276 for ConfigTest.testWriteIOS as well as for ConfigTest.testWriteConsole, or was it only for the latter?
―
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/TestingResearchIllinois/idoft/pull/1353*pullrequestreview-2519553755__;Iw!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYaipkhs3D$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AWDZON6NBZTAZVETAL6EI4T2GZHADAVCNFSM6AAAAABQFD5HC2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJZGU2TGNZVGU__;!!DZ3fjg!9yuTwio3nKdGgHbEjb1HdJ4yuAwXbAXvE0t4lpzxmjHJP9lhk-YpmBLj6MLssFjKsgCO2qLWGyXe4ByLSYdYalhd5c3x$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Okay, I've accepted by squashing 2 commits so we need not iterate more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a flacky test and updated two project status to developer fixed. Xinying Lyu