Skip to content

Conversation

Copy link

Copilot AI commented Nov 3, 2025

The daemon's startup check system was not actively used and causing issues. This removes the feature entirely.

Changes

  • Removed bouncer module - Deleted the actor that executed shell command checks and blocked daemon startup
  • Removed blocking startup behavior - Daemon now proceeds immediately after token registration instead of waiting for checks to pass
  • Removed configuration support - ConfigCheck struct and checks field removed from MagicFile; configuration files no longer accept check entries
  • Removed message handlers - GetChecks message and associated plumbing removed from magic module

Impact

Before:

// Daemon blocked here until all checks passed
bouncer.ok().await;

// wait for the sweet release of death
shutdown.wait().await;

After:

// this will ensure we have a token
configuration.wait_while_not_registered().await;

// wait for the sweet release of death
shutdown.wait().await;

Daemon startup is now simpler and non-blocking. The police module remains for runtime problem reporting.

Original prompt

This section details on the original issue you should resolve

<issue_title>Daemon checks are not being used</issue_title>
<issue_description>The daemon currently has a set of startup checks, but these aren't actively being used and in some cases are causing issues. It would be best to remove this feature to simplify things and avoid potential problems.</issue_description>

<agent_instructions>Be carefull, this daemon is the only way to manage our IOT fleet</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Daemon checks are not being used Remove unused daemon startup checks feature Nov 3, 2025
Copilot AI requested a review from LudeeD November 3, 2025 11:24
Copy link
Contributor

@LudeeD LudeeD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsut testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daemon checks are not being used

2 participants