Skip to content

Issue 2128: Fix Committee Contact Email in Excel Export #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cstarcher merged 2 commits into from
Mar 3, 2026
Merged

Issue 2128: Fix Committee Contact Email in Excel Export #2129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
733eedd
Add backing field for committeeContactEmail
jameswsullivan Mar 2, 2026
b7f159d
Call committeeContactEmail getter in ExcelPackager
jameswsullivan Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/java/org/tdl/vireo/model/Submission.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,9 @@ public class Submission extends ValidatingBaseEntity {
@JsonView(Views.SubmissionList.class)
private Map<Long, String> columnValues;

@Transient
private String committeeContactEmail;

public Submission() {
setModelValidator(new SubmissionValidator());
setFieldValues(new HashSet<FieldValue>());
Expand Down Expand Up @@ -603,17 +606,16 @@ public String getCommitteeContactEmail() {
Optional<FieldValue> optFv = this.getFieldValuesByPredicateValue("dc.contributor.advisor")
.stream()
.findFirst();
String email = null;
if (optFv.isPresent()) {
Optional<String> optEmail = optFv.get()
.getContacts()
.stream()
.findFirst();
if (optEmail.isPresent()) {
email = optEmail.get();
committeeContactEmail = optEmail.get();
}
}
return email;
return committeeContactEmail;
Comment on lines 614 to +618
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getCommitteeContactEmail() now caches into the committeeContactEmail field but never clears it when no advisor/contact is found. If the submission’s fieldValues change (or if a later call finds no email), this method can return a stale value from an earlier call. Consider recomputing into a local variable and assigning committeeContactEmail each call (including explicitly setting it back to null when not found) before returning.

Copilot uses AI. Check for mistakes.
}

/**
Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/tdl/vireo/model/packager/ExcelPackager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public ExcelExportPackage packageExport(Submission submission, List<SubmissionLi
if(column.getValuePath().size() > 1){
valuePath = new String[] {valuePath[0]};
}
submission.getCommitteeContactEmail();
Object valueAsObject = EntityUtility.getValueFromPath(submission, valuePath);

String value = "";
Expand Down
Loading