Skip to content

fix(option list): fix size when options removed or cleared #5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TomJGooding
Copy link
Contributor

@TomJGooding TomJGooding commented Apr 10, 2025

Fix the OptionList size not updating correctly after removing or clearing options.

Fixes #5728

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

Fix the OptionList size not updating correctly after removing options.

Fixes Textualize#5728 (comment)
Fix the OptionList size not updating correctly after clearing the
options.

Fixes Textualize#5728
@TomJGooding TomJGooding changed the title fix(option list): fix size when options removed fix(option list): fix size when options removed or cleared Apr 10, 2025
@TomJGooding TomJGooding marked this pull request as ready for review April 10, 2025 13:41
Copy link
Member

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willmcgugan willmcgugan merged commit 3b8713b into Textualize:main Apr 11, 2025
23 checks passed
@davep
Copy link
Contributor

davep commented Apr 11, 2025

Thanks @TomJGooding.

@TomJGooding TomJGooding deleted the fix-option-list-fix-size-when-options-removed branch April 11, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OptionList not fully updating on options being cleared (since v2.0.0)
3 participants