Use alias _App for App in type hints under TYPE_CHECKING #6152
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6158
Hi,
First of all, thanks for such a great library, really enjoy using it 🙌
I have found small issue.
App
imported in__init__
oftextual
, but it imported only inif TYPE_CHECKING
block, because of that mypy and other tools think thatfrom textual import App
is valid code.This PR will import
App
as_App
, so IDEs and other tools will show an error for:Please review the following checklist.