Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefix binding actions with app namespace #83

Conversation

TomJGooding
Copy link
Contributor

@TomJGooding TomJGooding commented Jun 5, 2024

Fixes #82 where Trojon bindings are broken in recent versions of Textual due to this change in Textual v0.61.0:

Breaking change: Actions (as used in bindings) will no longer check the app if they are unhandled. This was undocumented anyway, and not that useful. Textualize/textual#4516

@daneah
Copy link
Collaborator

daneah commented Aug 30, 2024

I've confirmed this has the desired effect in the application where I'm using Trogon.

@gaby gaby mentioned this pull request Sep 5, 2024
fresh2dev added a commit to fresh2dev/argparse-tui that referenced this pull request Sep 8, 2024
Use the lowest version of textualize for which the prefixed action
bindings are compatible, while also bumping the version of textual in
poetry.lock to the latest release.
@daneah daneah merged commit 8709b0c into Textualize:main Sep 20, 2024
15 checks passed
@daneah daneah added the bug Something isn't working label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trogon footer broken in Textual 0.60.0 and above
2 participants