Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Conan Example #222

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Fix Conan Example #222

merged 2 commits into from
Apr 6, 2022

Conversation

csegarragonz
Copy link
Contributor

@csegarragonz csegarragonz commented Apr 5, 2022

As mentioned in a related issue, the Conan example is broken. It uses version 0.4.0 that still installs picojson/1.3.0 as a dependency.

For code versions greater than 0.5.0, picojson is no longer installed as a dependency, and the provided example fails to build.

In this PR I provide a minimal fix, but you may prefer to change the Conan recipe altogether.

@prince-chrismc
Copy link
Collaborator

As mentioned in a related issue,

Sorry for not responding, I am "taking time off" so I was not able to answer #213 (comment)

But I am very glad you found the issue! I am super grateful you've gone above and beyond to contribute back and improve our example! 🚀 💟

picojson is no longer installed as a dependency... but you may prefer to change the Conan recipe altogether.

There a lot of context behind it but this is the intended usage... conan-io/conan-center-index#4644 (comment)

@prince-chrismc prince-chrismc merged commit e0f89e0 into Thalhammer:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants