Optimize Factorial Algorithm (Iterative Implementation) and Add Comprehensive JUnit Test Suite #7145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the existing
Factorialimplementation in thedivideandconquerpackage by replacing the recursive algorithm with an optimized iterative version. The new implementation reduces space complexity, avoids recursion overhead, and prevents stack overflow for moderately large inputs.In addition, this PR adds a comprehensive JUnit test suite to validate correctness, edge cases, performance behavior, and relative improvement compared to the original recursive approach.
✔ Algorithm Improvements
✔ Test Suite Added (
FactorialTest.java)The added JUnit test suite covers:
1. Basic Correctness
IllegalArgumentException2. Performance & Analysis
3. Demonstrating Algorithmic Improvement
Why This PR Is Valuable
Thank you for reviewing this contribution!