Skip to content

Fixes #12857 Use collections.deque as queue in graphs BFS shortest path - breadth_first_search_shortest_path_2.py #12861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes #12857 Use collections.deque as queue in graphs BFS shortest path - breadth_first_search_shortest_path_2.py #12861

wants to merge 3 commits into from

Conversation

john-liu2
Copy link

Describe your change:

Use collections.deque as queue in graphs BFS shortest path - breadth_first_search_shortest_path_2.py

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes Performance Enhancement: Replace list with collections.deque in graph algorithms #12857".

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass labels Jul 26, 2025
@john-liu2 john-liu2 requested a review from cclauss as a code owner July 26, 2025 21:25
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Jul 26, 2025
@cclauss
Copy link
Member

cclauss commented Jul 26, 2025

Why make the proposed change?
Is it faster?
Is it more memory efficient?
Do we really use both ends?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance Enhancement: Replace list with collections.deque in graph algorithms
2 participants
@john-liu2 @cclauss