Fixes Empty Footprints Being Left Behind in some Situations #2264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: YML
Changes: C#
Status: Needs Review
TheDen-Bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LICENSE: MIT
About the PR
Why / Balance
Footprints in the same tile as a puddle could end up empty and unable to be cleaned when the puddle on the tile is mopped.
Technical details
Issue is caused by DoTileReactions, specifically the spill tile reactions, directly removing the water from absorber split and spilling it into the tile.
When the 0 volume split is added to the footprint no SolutionContainerChanged event is sent, meaning the footprint is never deleted.
Media
Requirements
Breaking changes
Changelog
🆑