-
Notifications
You must be signed in to change notification settings - Fork 81
Feat: Migrate CircleCI actions to Github Actions #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: Migrate CircleCI actions to Github Actions #648
Conversation
(I think CircleCI might be broken because I've nuked the config file, so its trying to run something but doesn't know what) |
Would also close #477 |
bump |
@Asartea , thanks again for your patience. I want to get this merged in. I want to wrangle another maintainer just to give this a once over before we flip the switch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a maint anymore but for what it's worth, LGTM other than the below and the merge conflict
My review comments went AWOL...
Edit: There we go
Co-authored-by: MaoShizhong <[email protected]>
Okay, this PR is marked as having merge conflicts, but locally I can't find them, and the UI also tells me it can be cleanly merged |
@Asartea does this not end up showing you? If not, tj's changed files was bumped from v41 to v46 |
It does, but it tells me its too complex to resolve in web, and if I merge main into my branch locally it cleanly merges |
Okay merging and then pushing appears to have fixed it |
Too complex? 🤔 One hell of an off day for GitHub then... |
The funniest thing is, git merged without merge conflicts 🤷 |
Because
This PR
Issue
Closes #612
Closes #477
Additional Information
Example of how it looks:
Pull Request Requirements
location of change: brief description of change
format, e.g.Callbacks command: Update verbiage
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section