Skip to content

Feat: Migrate CircleCI actions to Github Actions #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Asartea
Copy link
Contributor

@Asartea Asartea commented Feb 7, 2025

Because

This PR

  • Migrates the eslint and jest actions to GitHub actions

Issue

Closes #612
Closes #477

Additional Information

Example of how it looks:

image
image
image

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR adds new features or functionality, I have added new tests
  • If applicable, I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

@Asartea
Copy link
Contributor Author

Asartea commented Feb 7, 2025

(I think CircleCI might be broken because I've nuked the config file, so its trying to run something but doesn't know what)

@MaoShizhong
Copy link
Contributor

Would also close #477

@JustWaveThings JustWaveThings added the Status: Under Review This issue/PR is being reviewed by at least one maintainer label Feb 18, 2025
@Asartea
Copy link
Contributor Author

Asartea commented Mar 3, 2025

bump

@JustWaveThings
Copy link
Contributor

@Asartea , thanks again for your patience. I want to get this merged in. I want to wrangle another maintainer just to give this a once over before we flip the switch.

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a maint anymore but for what it's worth, LGTM other than the below and the merge conflict

My review comments went AWOL...
Edit: There we go

Co-authored-by: MaoShizhong <[email protected]>
@Asartea
Copy link
Contributor Author

Asartea commented Mar 31, 2025

Okay, this PR is marked as having merge conflicts, but locally I can't find them, and the UI also tells me it can be cleanly merged

@MaoShizhong
Copy link
Contributor

@Asartea does this not end up showing you?
Screenshot_2025-03-31-11-49-05-21_e4424258c8b8649f6e67d283a50a2cbc

If not, tj's changed files was bumped from v41 to v46

@Asartea
Copy link
Contributor Author

Asartea commented Mar 31, 2025

It does, but it tells me its too complex to resolve in web, and if I merge main into my branch locally it cleanly merges

@Asartea
Copy link
Contributor Author

Asartea commented Mar 31, 2025

Okay merging and then pushing appears to have fixed it

@MaoShizhong
Copy link
Contributor

Too complex? 🤔 One hell of an off day for GitHub then...

@Asartea
Copy link
Contributor Author

Asartea commented Mar 31, 2025

The funniest thing is, git merged without merge conflicts 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Under Review This issue/PR is being reviewed by at least one maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CircleCI to GitHub Actions Ensure CircleCI tests get run for PR's from forks
3 participants