Merged
Conversation
jonathangreen
force-pushed
the
feature/lint
branch
2 times, most recently
from
91172da to
194e3e0
Compare
We lint with: - black - isort
jonathangreen
force-pushed
the
feature/lint
branch
from
194e3e0 to
86eb4ad
Compare
jonathangreen
force-pushed
the
feature/lint
branch
from
86eb4ad to
8485593
Compare
tdilauro
approved these changes
Nov 12, 2021
Contributor
tdilauro
left a comment
tdilauro
left a comment
There was a problem hiding this comment.
LGTM!
Caveat: I took a good look at the new GH workflow, the updated tox.ini, and a sampling of the linted files. I spot checked in another sample of files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similar to ThePalaceProject/circulation-core#22 this PR adds a linting step to our CI pipeline. The bulk of this PR is automatic reformatting done by isort and black.
This PR also removes old migrations. Some of them did not parse in Python 3 which was causing Black to fail in its linting. Seemed easier to remove them then make the changes to make them work in Python 3. I don't think we need to carry around these old migration files anyway.
Motivation and Context
Bring circulation into line with these PRs:
ThePalaceProject/circulation-core#22
ThePalaceProject/library-registry#23