feat: change attestation justification from bytes32 to bytes for unli… #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharshah21
requested review from
Teddy1792,
joelamouche and
oscarwroche
as code owners
Contributor
|
This looks good but we can't merge until I have deployed new contracts |
Contributor
|
@tusharshah21 I think we already have that in the frontend 🤔 pls resolve conflicts |
Collaborator
Author
|
okays on it captain |
Contributor
|
@tusharshah21 pls resolve conflicts |
Collaborator
Author
|
updated mate |
Contributor
|
"This branch cannot be rebased due to conflicts" 🤔 Are you sure you used rebase? |
tusharshah21
force-pushed
the
fix-33-attestation
branch
from
61de17d to
85943eb
Compare
Collaborator
Author
|
Hoping this covers now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
Change EAS schema justification field from bytes32 (32 byte limit) to bytes (unlimited).
Update encoding/decoding logic in frontend hooks and documentation accordingly.