fix(#154): support long badge descriptions #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V-Vaal
requested review from
Teddy1792,
joelamouche and
oscarwroche
as code owners
joelamouche
reviewed
Dec 16, 2025
Contributor
joelamouche
left a comment
joelamouche
left a comment
There was a problem hiding this comment.
Nice work!
No need for retrocompatibility here
V-Vaal
force-pushed
the
fix/154-badge-description-bytes
branch
from
b2c62c5 to
df7a93e
Compare
V-Vaal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for long badge descriptions by storing them as
bytes,while preserving full retrocompatibility.
What’s included
bytescreateBadgeV2getBadgeV2getBadgeAtV2BadgeCreatedV2eventTests
Closes #154