-
Notifications
You must be signed in to change notification settings - Fork 15
feat:150- Implement JWT authentication flow on frontend #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:150- Implement JWT authentication flow on frontend #159
Conversation
3dcd749 to
496180b
Compare
joelamouche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, but where is the logic for token expiration (defaults to 86400 in our backend)? Yu should probably store date in localstorage and use it to see if token expired
4d48428 to
179ed04
Compare
|
Thanks for the feedback! Both issues addressed:
|
joelamouche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress!
But there is still some work in order to provide a clean Log In UX and completely replace siwe with jwt
ab700fe to
be70264
Compare
|
All profile CRUD operations now:
Removed all SIWE signing UI from Create/Edit/Delete dialogs. Users now sign once on login, then all operations use the JWT token seamlessly. |
|
Okay looks great! 🚀 |
joelamouche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🌔
Create JWT storage utility for token management (localStorage)
Features:
Closes #150