refactor(network): use constexpr for NetPacket field type constants

Author: bobtista

Generals/Code/GameEngine/Source/GameNetwork/NetPacket.cpp

@@ -31,15 +31,16 @@
 #include "GameNetwork/NetworkDefs.h"
 #include "GameNetwork/networkutil.h"
 #include "GameNetwork/GameMessageParser.h"
+#include <Utility/CppMacros.h>
 
 // TheSuperHackers @refactor BobTista 10/06/2025 Extract magic character literals into named constants for improved readability
 namespace NetPacketFieldTypes {
-	const char CommandType = 'T';		// NetCommandType field
-	const char Relay = 'R';				// Relay field
-	const char PlayerId = 'P';			// Player ID field
-	const char CommandId = 'C';			// Command ID field
-	const char Frame = 'F';				// Frame field
-	const char Data = 'D';				// Data payload field
+	constexpr char CommandType = 'T';		// NetCommandType field
+	constexpr char Relay = 'R';				// Relay field
+	constexpr char PlayerId = 'P';			// Player ID field
+	constexpr char CommandId = 'C';			// Command ID field
+	constexpr char Frame = 'F';				// Frame field
+	constexpr char Data = 'D';				// Data payload field
 }
 
 // This function assumes that all of the fields are either of default value or are

GeneralsMD/Code/GameEngine/Source/GameNetwork/NetPacket.cpp

@@ -31,15 +31,16 @@
 #include "GameNetwork/NetworkDefs.h"
 #include "GameNetwork/networkutil.h"
 #include "GameNetwork/GameMessageParser.h"
+#include <Utility/CppMacros.h>
 
 // TheSuperHackers @refactor BobTista 10/06/2025 Extract magic character literals into named constants for improved readability
 namespace NetPacketFieldTypes {
-	const char CommandType = 'T';		// NetCommandType field
-	const char Relay = 'R';				// Relay field
-	const char PlayerId = 'P';			// Player ID field
-	const char CommandId = 'C';			// Command ID field
-	const char Frame = 'F';				// Frame field
-	const char Data = 'D';				// Data payload field
+	constexpr char CommandType = 'T';		// NetCommandType field
+	constexpr char Relay = 'R';				// Relay field
+	constexpr char PlayerId = 'P';			// Player ID field
+	constexpr char CommandId = 'C';			// Command ID field
+	constexpr char Frame = 'F';				// Frame field
+	constexpr char Data = 'D';				// Data payload field
 }
 
 // This function assumes that all of the fields are either of default value or are