forked from payrollhero/webhook_system
-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade tte-master to webhook system v2.2.1 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ayzahamid
wants to merge
60
commits into
tte-master
Choose a base branch
from
upgrade-to-webhook-system-v2.2.1
base: tte-master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github-actions switch to github actions instead of travis
* draft, add ability to call another job inline, this way we can keep our subscriptions and topics, but remove an external service * allow straight http, at least for the test suite * update validation * validation adjustment fixed inline job matcher * update url_domain for inline subscriptions, add specs * make Job trailing * update gemfile .lock for rails 4.2 Co-authored-by: P.T <[email protected]>
* allow rails 6.1+ * update Gemfile.lock for Rails 4.2 * add ruby 2.7 to the build matrix, bump version * bundle update for rails 4.2, remove byebug/pry from dev deps * moved exception expectation block inside * Update CHANGELOG.md * 2.3.1 is sufficient Co-authored-by: P.T <[email protected]>
* enable rubocop-challenger * fork of pr_comet * git ignore * need a initial rubocop_todo file * run on schedule
* 🚓 regenerate rubocop todo * 🚓 Style/FrozenStringLiteralComment * 🚓 regenerate rubocop todo
…DME and Changelog
* 🚓 regenerate rubocop todo * 🚓 Style/SymbolArray * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Style/StderrPuts * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Security/JSONLoad * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Lint/DeprecatedOpenSSLConstant * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Layout/SpaceInLambdaLiteral * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Lint/NonAtomicFileOperation * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]> Co-authored-by: Mathieu Jobin <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Style/FileWrite * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
…o#45) * 🚓 regenerate rubocop todo * 🚓 Layout/SpaceAroundEqualsInParameterDefault * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]> Co-authored-by: Mathieu Jobin <[email protected]>
- enable rubocop-rails, performance and rspec - remove hound file - update todo file
* 🚓 regenerate rubocop todo * 🚓 Layout/SpaceAroundOperators * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Style/IfUnlessModifier * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Style/RedundantSelf * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Layout/EmptyLinesAroundBlockBody * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 RSpec/ContextMethod * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* run rubocop on CI * specify config file Preventing to catch all files coming from dependencies * ignore all of vendor/bundle where gems gets installed on Github Actions * add ignores for BlockLength on commonly long rspec methods
* 🚓 regenerate rubocop todo * 🚓 RSpec/LeadingSubject * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]> Co-authored-by: Mathieu Jobin <[email protected]>
- we dont need to load the rails env in these tasks - the gem don't need application record/job base classes
* 🚓 regenerate rubocop todo * 🚓 Style/MutableConstant * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 RSpec/EmptyLineAfterFinalLet * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Style/Proc * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Rails/NegateInclude * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]> Co-authored-by: Mathieu Jobin <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 RSpec/DescribedClass * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Naming/RescuedExceptionsVariableName * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Style/PercentLiteralDelimiters * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 RSpec/ClassCheck * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Style/StringConcatenation * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
Co-authored-by: Rubocop Challenger <[email protected]>
…ro#101) * 🚓 regenerate rubocop todo * 🚓 RSpec/FactoryBot/ConsistentParenthesesStyle * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Bundler/OrderedGems * 🚓 regenerate rubocop todo Co-authored-by: Rubocop Challenger <[email protected]>
* enforce rspec to_not rule over not_to * regen fresh rubocop todo with exclude-limit 180 * ignore this rule * add comment * new lock file for 4.2, but faraday 2.x will make everything fail, right? * ruby 2.5 support is removed, skip CI --------- Co-authored-by: Mathieu Jobin <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Style/SlicingWithRange * 🚓 regenerate rubocop todo --------- Co-authored-by: Rubocop Challenger <[email protected]> Co-authored-by: Mathieu Jobin <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Style/GuardClause * 🚓 regenerate rubocop todo --------- Co-authored-by: Rubocop Challenger <[email protected]> Co-authored-by: Mathieu Jobin <[email protected]>
* 🚓 regenerate rubocop todo * 🚓 Lint/NonDeterministicRequireOrder * 🚓 regenerate rubocop todo * remove exclude --------- Co-authored-by: Rubocop Challenger <[email protected]> Co-authored-by: Mathieu Jobin <[email protected]> Co-authored-by: Mathieu Jobin <[email protected]>
* allow rails 7.1 * Update ci.yml * Create rails_7.1.gemfile * Update version.rb * update rubocop file * dev branch of active_attr * bye bye ruby 2.6 * updte rubocop * bye bye rails 4.2 * oups * we need this * one was missing * fix version check * ruby 3.0 only for rails 7.1 * rails 7.1 on ruby 3.1+ only * used released active_attr
1. Update faraday 2. Rename `encrypt` -> `encrypted` 3. Don't break `dispatch` if we don't have `secret` 4. Wrap payload in `data` key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.