Skip to content

gpg: ensure LC_MESSAGES so that regex match the output. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasHabets merged 1 commit into from
Jan 10, 2026
Merged

gpg: ensure LC_MESSAGES so that regex match the output. #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/gpg/gpg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ func (gpg *GPG) Decrypt(ctx context.Context, dec string) (string, *Status, error
var stderr bytes.Buffer
var stdout bytes.Buffer
cmd := exec.CommandContext(ctx, gpg.GPG, "--batch", "--no-tty")

// Ensure that US gpg strings are used in gpg tp match regexp.
cmd.Env = append(os.Environ(), "LC_MESSAGES=C")

if gpg.Passphrase != "" {
// Used for testing.
cmd.Args = append(cmd.Args,
Expand Down Expand Up @@ -105,6 +109,10 @@ func (gpg *GPG) Verify(ctx context.Context, data, sig string) (*Status, error) {

var stderr bytes.Buffer
cmd := exec.CommandContext(ctx, gpg.GPG, "--verify", "--no-tty", sigFN, dataFN)

// Ensure that US gpg strings are used in gpg tp match regexp.
cmd.Env = append(os.Environ(), "LC_MESSAGES=C")

cmd.Stderr = &stderr
if err := cmd.Start(); err != nil {
return nil, errors.Wrapf(err, "failed to start gpg (%q)", gpg.GPG)
Expand Down Expand Up @@ -144,6 +152,10 @@ func (gpg *GPG) Verify(ctx context.Context, data, sig string) (*Status, error) {
func (gpg *GPG) VerifyInline(ctx context.Context, data string) (*Status, error) {
var stderr bytes.Buffer
cmd := exec.CommandContext(ctx, gpg.GPG, "--verify", "--no-tty", "-")

// Ensure that US gpg strings are used in gpg tp match regexp.
cmd.Env = append(os.Environ(), "LC_MESSAGES=C")

cmd.Stderr = &stderr
cmd.Stdin = strings.NewReader(data)
if err := cmd.Start(); err != nil {
Expand Down