feat(cmdg): implement robust inline image rendering and non-blocking UI#150
Closed
kurokirasama wants to merge 1 commit into
Closed
feat(cmdg): implement robust inline image rendering and non-blocking UI#150kurokirasama wants to merge 1 commit into
kurokirasama wants to merge 1 commit into
Conversation
Contributor
Author
|
hey!! not sure if you'll approve this since introduces quite a few changes but I think is a great feature and actually struggle quite a bit to make it work ;) |
Owner
|
It needs to be rebased, as it's undoing some lint changes. Or somehow suppress those lints. But after that, yes this is a lot of code liability to take on. Maybe it would be better to have this email rendering be an external tool (separate repo), and instead just have cmdg interface with it. Similar to how lynx can currently be used to render the email. |
Contributor
Author
|
Hey, thanks for the feedback, i'll think about what you suggested and the best way to achieve it. Regards, |
kurokirasama
force-pushed
the
master
branch
7 times, most recently
from
cf7bc57 to
a71a85d
Compare
- Integrated a custom C-based HTML renderer (Matcha engine) for high information density. - Implemented support for Kitty and iTerm2 terminal image protocols. - Added pixel-perfect vertical clipping and smooth scrolling for images. - Refactored message loading to be non-blocking with background resolution. - Optimized performance with parallel image resolution. - Added automatic terminal protocol detection. - Scrubbed all engine-specific branding from user-facing output.
Contributor
Author
|
finally passed all check, but i'll close to work on the external tool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements robust inline image rendering for the cmdg terminal client.
Key Features:
Supported Terminals: Ghostty, Kitty, iTerm2, WezTerm, and other modern terminals with Kitty protocol support.