Skip to content

handle situation where there is no environment variables / HOME at all#45

Open
maage wants to merge 1 commit into
ThomasHabets:masterfrom
maage:env-home
Open

handle situation where there is no environment variables / HOME at all#45
maage wants to merge 1 commit into
ThomasHabets:masterfrom
maage:env-home

Conversation

@maage

@maage maage commented Oct 11, 2018

Copy link
Copy Markdown

At least current openssh 7.8p1 does use ssh-pkcs11-helper and it does not have any envs defined. To be able to read config we need to get home so get it via getpwuid. I did not test failure modes, but it is possible to have user without entry in the passwd.
Without this patch ssh-add -s fails and ssh-pkcs11-helper either dies or dumps core. As ssh-agent does not reap or restart helpers it is kind of bad.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ThomasHabets ThomasHabets self-assigned this Dec 3, 2018
@ThomasHabets

Copy link
Copy Markdown
Owner

I'm still waiting for CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants