Data Package should contain a publishers.jl file too #269
Conversation
|
The aggregates on publisher are updated by the "rewrite_quality_data" command, not the "manage_entities_data" command - maybe this should be added to the "Updating entities data" section in the Readme? Also, I can see Publisher's are created by https://github.com/ThreeSixtyGiving/datastore/blob/live/datastore/db/management/commands/load_datagetter_data.py#L142 but I can't see where they are deleted. |
Also, on reading the code I wasn't certain getter_run was being updated properly on publisher. https://github.com/ThreeSixtyGiving/datastore/blob/live/datastore/db/management/commands/load_datagetter_data.py#L142 uses get_or_create to populate the publisher variable, but I couldn't see anywhere in the following code that the publisher variable is actually saved. There is an update_or_create method that may be what is wanted here? But this is just from reading code, I didn't test to double check this. |
| @@ -87,20 +87,32 @@ def create_orgs_list(entity_type, output=sys.stdout): | |||
| entity_type: publisher, recipient, funder | |||
There was a problem hiding this comment.
Interesting comment, I wasn't sure if it ever worked in the past or was just planned to work at some point in the future
| LEFT OUTER JOIN additional_data_orginfocache on db_{entity_type}.org_id = additional_data_orginfocache.org_id | ||
| LEFT OUTER JOIN db_publisher on db_{entity_type}.org_id = db_publisher.org_id OR db_publisher.org_id = ANY(db_{entity_type}.non_primary_org_ids) | ||
| """ | ||
| if entity_type == "publisher": |
There was a problem hiding this comment.
I did try one query var and several ("" if x else "") in the middle but it seemed like this way was way more readable.
ThreeSixtyGiving/grantnav#862