codelists: added titles to countryCode.csv #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to #349 which stipulated a requirement for titles in countrycodes. List of titles was taken from the ISO 3166-1 alpha-2 codes, which corresponds with the codes used in this codelist. The wikipedia article suggests that these are the titles used by the ISO 3166 maintenance agency. It should be acknowledged that this is not necessarily a value-neutral list of names. Amendment was done mechanically through copying the wikipedia table to a spreadsheet, exporting as CSV and then merging via csvkit. Manual tidying for strings done afterwards
|
Hi @KDuerden, this PR raised in response to #349. I believe this is a PATCH because no codes have changed, we've just added the missing "Title" column to each code. I have also taken the liberty of wrapping all the strings in "" characters to ensure proper parsing, although we can probably safely remove them around the codes themselves if we felt the need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #349 which stipulated a requirement for titles in countrycodes.
List of titles was taken from the ISO 3166-1 alpha-2 codes, which corresponds with the codes used in this codelist. The wikipedia article suggests that these are the titles used by the ISO 3166 maintenance agency.
It should be acknowledged that this is not necessarily a value-neutral list of names.
Amendment was done mechanically through merging a table of the ISO 3166-1 alpha-2 codes and titles into the codelist file via csvkit. Manual tidying for strings done afterwards