Skip to content
This repository was archived by the owner on Dec 7, 2019. It is now read-only.

Conversation

NOTtheMessiah
Copy link

KSPAPIExtension's functionality has been integrated into the mod (via KSPUtils.cs, UnityUtils.cs, EngineWrapper.cs, and MathUtils.cs) yet the Makefile hasn't been updated to reflect this in 3 years.

KSPAPIExtension's functionality has been integrated into the mod (via KSPUtils.cs, UnityUtils.cs, EngineWrapper.cs, and MathUtils.cs) yet the Makefile hasn't been updated to reflect this in 3 years.
"Consider adding a reference to assembly `UnityEngine.UI, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'"
$e

RESGEN2 := resgen2
GMCS := gmcs
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing gmcs to mcs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using Mono, which has unified the various c# compilers into mcs. I don't know if this is the case on other systems or not.

https://www.mono-project.com/docs/about-mono/languages/csharp/

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So Mono 2.11 unified them. If this is the case, replace the GMCS variable with MCS as well. GMCS := gmcs makes sense but GMCS := mcs does not.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, it would be good to add -langversion:ISO-2 -sdk:2 after ${GMCS} to make sure we target the same version as gmcs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thought, but it won't compile because there's lambda expressions and other language features used not in the C# 2.0 specification.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants