feat: add optional external browser via Chrome DevTools Protocol - #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser_cdp_urlconfig setting (also settable viaTINYSEARCH_BROWSER_CDP_URL) that connects Crawl4AI to an externally-managed Chrome browser over CDP instead of TinySearch's bundled Chromium.doctorverifies the external browser is reachable, and the CDP endpoint is treated as operator-managed: redacted inGET /configand rejected (403) fromPUT /configso it can only be changed via env var or config file + restart.Test plan
uv run python -m unittest discover -s tests -p "test_*.py"— 261 passed, 1 skippedbrowser_cdp_urlat a real Chrome instance with--remote-debugging-portand confirmresearch/scrapework end-to-end