-
Notifications
You must be signed in to change notification settings - Fork 31
Collecting hopefully useful info for newly-joined contributors to start. #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ha5se
wants to merge
6
commits into
Tlf:master
Choose a base branch
from
ha5se:README_beginner_developer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c1a4d62
Collecting hopefully useful info for newly-joined contributors to start.
ha5se cdbefd4
Collecting hopefully useful info for newly-joined contributors to start,
ha5se 00c2909
Merge branch 'README_beginner_developer' of github.com:ha5se/tlf into…
ha5se 4e74614
Delete non-md file, minor rephrasing
ha5se 6198eb7
Minor corrections and clarifications
dl1jbe 42bf2bd
Merge pull request #1 from dl1jbe/README_beginner
ha5se File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
# Tlf ham radio contest logger | ||
|
||
## Summary | ||
|
||
started by HA5SE | ||
|
||
This is some collection to help recently joined coders to start with | ||
contributing to TLF. | ||
You can try the hard way. Then you just do not need to read any further. | ||
Believe me, at least for me, it added unnecessary frustration that there were | ||
no such collection. | ||
You lean back, feeling (almost) on top of the World -- just to have to | ||
learn somewhat later when asking for merge your work, that you are far from done... | ||
|
||
In spite of every effort, this doc will (and can) never become complete. | ||
Any comments, critisisms, suggestions, improvement requests are | ||
_ W E L C O M E . | ||
|
||
To begin with, each project using any computer language, ususally is built upon | ||
* partly some project conventions | ||
* partly some personal tastes. | ||
|
||
Individual tastes are no problem for one-man projects. | ||
However, for bigger and long-lasting projects, individual tastes obviously | ||
do not help readibility or maintenability. | ||
My personal note, project conventions are also mainly built up of | ||
personal taste of somebody in the project much before you joined ;-) ... | ||
|
||
The following is the list we could collect so far. | ||
This list is only numbered for easy reference. | ||
This list is not considered to be sorted upon importance, | ||
nor do I think there could be any such importance. | ||
Please never re-number this list, that is, only add new points at end of file. | ||
In case anybody feels in absolute need of picking some points upon importance, | ||
please simply use a list in the header immediately below this introduction, like: | ||
|
||
**`important by HA5SE: 1, 2, 3 // sample`** | ||
|
||
|
||
|
||
## Currently documented conventions | ||
|
||
|
||
1) TLF is a combination of old code mixed with many new updates. | ||
Old code is as-is, you should never count on conventions in old | ||
code would still continue to be considered as current. | ||
|
||
Recent code often uses different conventions. Try to adapt your code to | ||
the modern ones. | ||
|
||
You can check the age of any line or block using | ||
|
||
**`git blame ...`** | ||
|
||
|
||
2) No need to update **` Changelog `** . It only will be updated once for all changes | ||
per each single new release by the maintainer. [thanks to HA5CQZ] | ||
|
||
|
||
3) In turn, it is your responsibility to update the manual page | ||
**` tlf.1.in `** if your contribution | ||
brings in visible changes to end-users. Such changes include e.g. new | ||
config keywords. | ||
|
||
|
||
4) Do not include your callsign or reason or similar in your modification, | ||
just add the ideas behind to the commit message and/or the pull request. | ||
Git will take care for recording it together with your authorship. | ||
[thanks to HA5CQZ] | ||
So there is no need to insert anything like | ||
|
||
**`// 2021-02-01 HA5SE implementing TUNE_LNG=`** | ||
|
||
Instead of comments like that, rather count on | ||
|
||
**`git blame`** and/or **`git log`** | ||
|
||
|
||
5) When defining global variables we have two choices: [thanks to DL1JBE] | ||
|
||
* Variables which are only part of an module should be defined in | ||
the module itself and made known to other modules by declaring them | ||
`extern` in the modules header file. | ||
* Alternatively if the variable is not clearly related to a | ||
functional module we have concentrated them in one place - at the | ||
moment in **` main.c `** (with **` test/data.c `** a | ||
shadow copy for testing purposes). | ||
The variable should then be declared `extern` in **` globalvars.h `** . |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this line in README.md, there is a link to http://travis-ci.org , no idea what for, Anyway, now I get
Please be aware travis-ci.org will be shutting down in several weeks, with all accounts migrating to travis-ci.com.
Could somebody please resolve this case please...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #246 (comment), commented the wrong thread