Fixed crossbows, implemented fireworks both as ammo for crossbows and as standalone items#84
Open
RyeWollschlaeger wants to merge 8 commits into
Open
Fixed crossbows, implemented fireworks both as ammo for crossbows and as standalone items#84RyeWollschlaeger wants to merge 8 commits into
RyeWollschlaeger wants to merge 8 commits into
Conversation
… as standalone items
11299de to
9a38e0e
Compare
d9c64c0 to
9a38e0e
Compare
added 2 commits
April 5, 2026 12:16
…e shooter's velocity
Author
|
Crossbows don't take item damage when shot. I don't know why. I'll need to look into that more |
Owner
|
I simplified the crossbow loading logic, also fixing an issue where other players would not see the animation when you hold right mouse button for longer than the loading time (Minestom's |
Author
The bug seems to be gone now thank you. I'll add a commit removing the TODO and add some minor fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crossbows were broken, the multishot enchantment was hardcoded to only shoot 3 arrows at a time no matter the enchantment level, and having too high quick charge lead to an item use duration of 0, which also broke the crossbows. Also implemented fireworks as ammo for crossbows, and to be able to be placed down normally.
Also made
lerp(),prevPitchandprevYawprotected instead of private, and editedshootFromRotation()to use a different formula for it's yaw, which orbits around the shooter, instead of having the same pitch no matter what (this was needed for vanilla multishot parity).Closes #75