Skip to content

Conversation

JankiGadhiya
Copy link
Contributor

Fixed #1300

@JankiGadhiya JankiGadhiya requested a review from a team as a code owner September 12, 2025 08:10
@CLAassistant
Copy link

CLAassistant commented Sep 12, 2025

CLA assistant check
All committers have signed the CLA.

@Zabuzard Zabuzard added the enhancement New feature or request label Sep 15, 2025
@Zabuzard
Copy link
Member

Looks good so far :) Id like to see a screenshot of it in Discord, maybe we want a few minor tweaks on the text then.
Ill check it out locally and do the local testing myself if you have not setup your testing-bot yet 👍

@Zabuzard
Copy link
Member

license/cla was signed (probably with wrong account but its fine)

@Zabuzard
Copy link
Member

I did some smaller improvements to the code while doing the local testing right away:

  • gradle:spotlessApply to get rid of formatting issues
  • replaced text building by "...".formatted(...), more readable
  • changed the text from and x attachments: (...) to (The message has x attachments: ...)

@Zabuzard
Copy link
Member

Local testing:

No text

empty message

No attachments

no attachment

Both

both

@Zabuzard Zabuzard merged commit 511c485 into Together-Java:develop Sep 15, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit message for attachment-scam is empty
3 participants