formatLicensePlateWithDashes and handleCharacterDeletion use hard-coded literal indices#117
Merged
TomerPacific merged 6 commits intomainfrom Mar 20, 2026
Conversation
TomerPacific
added
invalid
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Israeli license plate formatting/deletion logic in LicensePlateNumberDialog.kt by replacing hard-coded substring indices with named constants and adding brief documentation for the supported 7- and 8-digit formats.
Changes:
- Added documented, descriptive constants for dash/group indices used during formatting.
- Updated
handleCharacterDeletionto use the new constants instead of literal indices. - Updated
formatLicensePlateWithDashesto use the new constants for both 7- and 8-digit formatting paths.
app/src/main/java/com/tomerpacific/caridentifier/screen/LicensePlateNumberDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/tomerpacific/caridentifier/screen/LicensePlateNumberDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/tomerpacific/caridentifier/screen/LicensePlateNumberDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/tomerpacific/caridentifier/screen/LicensePlateNumberDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/tomerpacific/caridentifier/screen/LicensePlateNumberDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/tomerpacific/caridentifier/screen/LicensePlateNumberDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/tomerpacific/caridentifier/screen/LicensePlateNumberDialog.kt
Show resolved
Hide resolved
TomerPacific
deleted the
feature/extract-magic-numbers-formatLicensePlateWithDashes
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112
This pull request refactors the handling and formatting of Israeli license plate numbers in the
LicensePlateNumberDialog.ktfile to improve clarity and maintainability. The main changes involve replacing ambiguous constants with more descriptive ones and updating the formatting logic to use these new constants, making the code easier to understand and modify.Refactoring and code clarity improvements:
FIRST_DASH_INDEX,SECOND_DASH_INDEX) with descriptive constants for 7- and 8-digit license plate formats (e.g.,SEVEN_DIGIT_FIRST_DASH_INDEX,SEVEN_DIGIT_SECOND_DASH_INDEX, etc.), and added documentation explaining the different formats.handleCharacterDeletionfunction to use the new descriptive constants for substring operations, improving readability and reducing the risk of errors.formatLicensePlateWithDashesfunction to use the new constants, aligning formatting logic with the clarified license plate formats.