Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds VIN (frame number) visibility to the car details UI, addressing issue #115 by surfacing an already-deserialized field and providing localized label/tooltip text.
Changes:
- Display
frameNumber(VIN) inCarInformationviaCarDetailWithIconwith an icon + tooltip. - Add localized string resources for the VIN label and tooltip in Hebrew and English.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/src/main/java/com/tomerpacific/caridentifier/composable/CarInformation.kt | Adds a new detail row to show the car’s VIN/frame number with an icon + tooltip. |
| app/src/main/res/values/strings.xml | Adds Hebrew label + tooltip strings for frame number (VIN). |
| app/src/main/res/values-en/strings.xml | Adds English label + tooltip strings for frame number (VIN). |
app/src/main/java/com/tomerpacific/caridentifier/composable/CarInformation.kt
Show resolved
Hide resolved
app/src/main/java/com/tomerpacific/caridentifier/composable/CarInformation.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #115
This pull request adds support for displaying the car's frame number (VIN) in the car information view, including localized labels and tooltips in both English and Hebrew. The most important changes are:
UI Enhancement:
CarDetailWithIconcomponent to display the frame number (VIN) with an associated icon and tooltip in theCarInformationcomposable.Localization:
frame_number) in both English and Hebrew string resource files. [1] [2]frame_number_tooltip_explanation) in both English and Hebrew string resource files.